Some malformed sieve filters are not rejected.

[JulienPalard]

Contribution guidelines

• I've read the contribution guidelines and wholeheartedly agree

I've found a bug and checked that ...

• ... I understand that not following the below instructions will result in immediate closure and/or deletion of my issue.
• ... I have understood that this bug report is dedicated for bugs, and not for support-related inquiries.
• ... I have understood that answers are voluntary and community-driven, and not commercial support.
• ... I have verified that my issue has not been already answered in the past. I also checked previous issues.

Description

Bonjour,

In the filter interface, many typos are properly found and cause the whole script to be rejected, with a redish error message, this is good.

Sadly a few minor errors are **not** detected, leading to a greenish success message (misleading for the user!). Because as the script contains errors it will **not** be applied at all at runtime.

A simple example is:


require ["fileinto"];

if address :is "To" "[email protected]" {
    fileinto :create "pouette";
}


The error here is the missing `mailbox` requirement.

Logs:

ø

Steps to reproduce:

1. Go to the sieve filter editor
2. Copy past my previous example
3. Save it, see green success messag
4. Test the sieve filter by sending an email to your test mailbox
5. See that the filter has not been applied.

Which branch are you using?

master

Which architecture are you using?

x86

Operating System:

ø

Server/VM specifications:

ø

Is Apparmor, SELinux or similar active?

ø

Virtualization technology:

ø

Docker version:

ø

docker-compose version or docker compose version:

ø

mailcow version:

ø

Reverse proxy:

ø

Logs of git diff:

ø

Logs of iptables -L -vn:

ø

Logs of ip6tables -L -vn:

ø

Logs of iptables -L -vn -t nat:

ø

Logs of ip6tables -L -vn -t nat:

ø

DNS check:

All those mandatory field are a PITA when reporting a front-end issue.