Automatically import widgets #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in Django templates)
ClmntBcqt
changed the title
lebouquetin
requested changes
Jul 12, 2024
README.md
Outdated
|
|
||
| `./manage.py list-widgets` to list all widgets found in content directories | ||
|
|
||
| `./manage.py make-widgets` to make a file that groups all jinja2 widgets macros for easier includes. It is called by `runserver` and `distill-local` commands. \ |
There was a problem hiding this comment.
It is called by runserveranddistill-local commands.
-> It is automatically called by runserveranddistill-local commands.
| @@ -0,0 +1,8 @@ | |||
| import importlib | |||
There was a problem hiding this comment.
I'm not sure why you added the distill-local command. Is this a way to override the default distill-local command? If so, add a command explaining that the reason for this command to be locally defined is only to add the call to make-widgets as a precommand.
|
|
||
| n = 0 | ||
| for template_dir in settings.JFME_TEMPLATES_DIRS : | ||
| for widget in (template_dir / options["engine"] / "widgets").rglob("*") : |
There was a problem hiding this comment.
It looks like a widget is a file, here. What I expected is a list of all "macro" (actually, there may be several macro in one file, doesn't it?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #16