Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Consider using symlink or hardlink to replace the need for file_ext parameter. #260

Open
inkhey opened this issue Jul 6, 2021 · 0 comments
Labels
Architecture Improvment need rework on architecture of the software enhancement

Comments

@inkhey
Copy link
Contributor

inkhey commented Jul 6, 2021

Feature description and goals

Introduced here: #24 for tracim v2 support, the file_ext parameter permit to add extension separated from the filename. This is useful for filedepot file path as filedepot store file without extension.

This feature cause some issue as it create new case that also need to be tested.

To simplify things, it may be better to either:

  • ask user to always specify extension and document how to use sym/hard link for this. (hard/symlink to be done outside of preview-generator)
  • give both filename and mimetype, have some code that generated file_extension from mimetype which override the file_extension include in filename if needed and create a temporary sym/hardlink with the new filename to work on.

This permit to simplify the process.

It's unclear if symlink can work as expected. Hardlink seems more reliable for this but have some drawback too (weird result in du tool for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Improvment need rework on architecture of the software enhancement
Projects
None yet
Development

No branches or pull requests

1 participant