Get current segment number from segment filename when updating HLS storage sequences #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implimentation is not smart enough to discover when discontinuities have caused the segment number to increment, causing a mis-match between the stored sequence numbers and the current 'preload-hint' partial. It would be possible to get rid of Regex.named_captures by including the segment number in the metadata send by Membrane.HTTPAdaptiveStream.Storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is not smart enough to discover when discontinuities have caused the segment number to increment, causing a mis-match between the stored sequence numbers and the current published 'preload-hint' partial.
This PR uses the filename to get the segment number but could be improved by including the segment number in the metadata sent by Membrane.HTTPAdaptiveStream.Storage
fixes #133