CI: update reviewdog warning linter job #6175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
changed the title
cce
force-pushed
the
reviewdog-warnings
branch
from
8648463
to
c65c3a9
Compare
gmalouf
previously approved these changes
Nov 19, 2024
algorandskiy
previously approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6175 +/- ##
==========================================
+ Coverage 51.87% 51.90% +0.02%
==========================================
Files 639 639
Lines 85492 85492
==========================================
+ Hits 44352 44375 +23
+ Misses 38327 38308 -19
+ Partials 2813 2809 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
cce
force-pushed
the
reviewdog-warnings
branch
from
62ad8ee
to
3bed8af
Compare
gmalouf
approved these changes
Nov 20, 2024
algorandskiy
approved these changes
Nov 21, 2024
jannotti
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes how the reviewdog warning linter is configured (to match flags used by the reviewdog errors linter); changes cache key for loading previous builds of golangci-lint; and updates the gosec exclude list.
Test Plan
Should reliably make reviewdog warnings report on all builds.