Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

实现基于校验envoy配置的e2e test #703

Closed
johnlanni opened this issue Dec 18, 2023 · 4 comments · Fixed by #710
Closed

实现基于校验envoy配置的e2e test #703

johnlanni opened this issue Dec 18, 2023 · 4 comments · Fixed by #710
Assignees
@sjcsjc123
Labels
area/e2e level/challenge sig/ops

Comments

@johnlanni
Copy link
Collaborator 

          @sjcsjc123 可以参考下hgctl gateway-config的方式，通过校验envoy配置来做e2e test

Originally posted by @johnlanni in #699 (comment)
@johnlanni johnlanni added area/e2e help wanted Extra attention is needed labels Dec 18, 2023
@github-project-automation github-project-automation bot moved this to Todo in Higress Dec 18, 2023
@johnlanni johnlanni mentioned this issue Dec 18, 2023
Merged
@sjcsjc123
Copy link
Collaborator

可以尝试一下

@johnlanni johnlanni removed the help wanted Extra attention is needed label Dec 18, 2023
@johnlanni johnlanni moved this from Todo to In Progress in Higress Dec 18, 2023
@2456868764
Copy link
Collaborator

这个要重新包装一下 1. 有些公共方法要迁移 2. 看能否包装成便于测试断言模式

@sjcsjc123
Copy link
Collaborator

已经弄明白gateway-config的原理了，参考gateway-config获取对应的envoyfilter部分后如何校验呢，只要有下发相应的envoyfilter文件就算校验成功吗

@johnlanni
Copy link
Collaborator Author

已经弄明白gateway-config的原理了，参考gateway-config获取对应的envoyfilter部分后如何校验呢，只要有下发相应的envoyfilter文件就算校验成功吗

是的，校验对应的kv是否是配置的项

@sjcsjc123 sjcsjc123 mentioned this issue Dec 18, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Higress Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjcsjc123 sjcsjc123

Labels
area/e2e level/challenge sig/ops
Projects
Higress
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add e2e test for envoy filter sjcsjc123/higress
3 participants
@johnlanni @sjcsjc123 @2456868764