Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileMetricManagerReporter#timestampPrecision单位转换BUG #33

Open
vision57 opened this issue Apr 15, 2019 · 0 comments
Open

FileMetricManagerReporter#timestampPrecision单位转换BUG #33

vision57 opened this issue Apr 15, 2019 · 0 comments

Comments

@vision57
Copy link

https://github.com/dubbo/metrics/blob/49e2ec8d876fc2ce2e1ef99c4cc3ad9add5d60c8/metrics-reporter/src/main/java/com/alibaba/metrics/reporter/file/FileMetricManagerReporter.java#L257

这里单位转换我无法理解，我感觉正确的应该是if (TimeUnit.SECONDS.equals(timestampPrecision))，这样的代码整个库中有好几处，可以全局查找关键字timestampPrecision，不知道是不是BUG呢？
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vision57