Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bumping protobuf-java to 3.22+ #10137

Closed
n1x0l4s opened this issue Mar 19, 2023 · 7 comments
Closed

Consider bumping protobuf-java to 3.22+ #10137

n1x0l4s opened this issue Mar 19, 2023 · 7 comments
Labels
contribution welcome dependencies Pull requests that update a dependency file

Comments

@n1x0l4s
Copy link

n1x0l4s commented Mar 19, 2023

Building the project, I get class access errors, like protocolbuffers/protobuf#11986

the related commit is protocolbuffers/protobuf@c658e27

@n1x0l4s n1x0l4s changed the title Consider bump protobuf-java to 3.22+ Consider bumping protobuf-java to 3.22+ Mar 19, 2023
@KomachiSion
Copy link
Collaborator

I can't reproduce the problem when building project, What's your env information?

@n1x0l4s
Copy link
Author

n1x0l4s commented Mar 20, 2023

Fresh clone from branch develop with aliyun's maven mirror, the OS is Windows, the build produced emptyList() is not public in LazyStringArrayList; cannot be accessed from outside package and thus searched for a bit and provided related protobuf commit. Would you elaborate what other environment details needed to be addressed?

@KomachiSion
Copy link
Collaborator

KomachiSion commented Mar 21, 2023

I use linux sys or mac sys to do build with jdk8 and jdk11. It works well.

The maven mirror is default open repo.

@KomachiSion
Copy link
Collaborator

I don't has window sys and no use window sys to build. Need community help to test.

About the protobuf-java version, If upgrade 3.22+ has no compatibility issues, It can be upgrade without immediatly.

@n1x0l4s
Copy link
Author

n1x0l4s commented Mar 21, 2023

For now leave the issue open as force loading protobuf-java 3.22.2 here on my local dev machine solves the issue. I suggest closing this after verifying upgrade compatibility.

@KomachiSion KomachiSion added dependencies Pull requests that update a dependency file and removed status/need feedback labels Mar 27, 2023
@KomachiSion
Copy link
Collaborator

Welcome submit PR.

@n1x0l4s
Copy link
Author

n1x0l4s commented Mar 28, 2023

Upon further inspection, this non issue is local since my former build generated entity from protoc 3.22 which has compability conflits with protobuf-java 3.21.11. The protoc maven plugins were locally masked by local maven profile settings.
Since no .emptyList() from protobuf project is being used in this code base, the upstream change has no affect, thus closing the issue.

@n1x0l4s n1x0l4s closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants