Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to iframe #78

Closed
wants to merge 1 commit into from
Closed

Add title to iframe #78

wants to merge 1 commit into from

Conversation

idaons
Copy link

@idaons idaons commented Jan 4, 2021

Add title attribute to iframe in order to pass accessibility tests

Add title attribute to iframe in order to pass accessibility tests
@GreggSetzer
Copy link

@idaons, thank you for opening this PR. In addition, we might consider adding role="presentation" to remove the semantic meaning of the iframe. Since a user won't be interacting with this iframe, we can just strip if of semantics.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants