Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate is a noop #46

Closed
jamesplease opened this issue Aug 3, 2017 · 3 comments
Closed

generate is a noop #46

jamesplease opened this issue Aug 3, 2017 · 3 comments

Comments

@jamesplease
Copy link
Contributor

Hi there!

I'm trying to use this CLI for the first time, and it must be that I'm making a silly mistake. When I run all-contributors generate, nothing happens.

I ran the init script, then added a contributor:

{
  "projectName": "resourceful-redux",
  "projectOwner": "jmeas",
  "files": [
    "README.md"
  ],
  "imageSize": 100,
  "commit": true,
  "contributors": [
    {
      "login": "jmeas",
      "name": "James, please",
      "avatar_url": "https://avatars3.githubusercontent.com/u/2322305?v=4",
      "profile": "http://www.jmeas.com",
      "contributions": [
        "code",
        "plugin",
        "doc"
      ]
    }
  ]
}

README.md exists. I also created CONTRIBUTORS.md for kicks. Neither of these files are updated when I run generate.

I'm sure I'm just missing something basic. I looked through #6 for ideas, but nothing seemed to stand out as a mistake that I was making. Any thoughts?

Thanks for reading!

@jamesplease
Copy link
Contributor Author

jamesplease commented Aug 3, 2017

I dug into the code, and was able to fix it by manually adding:

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- ALL-CONTRIBUTORS-LIST:END -->

into the files that I was trying to update. I'm going to close this issue for now, but if this is a step that I should add to the README, let me know and I'll PR it.

Thanks!

@kentcdodds
Copy link
Collaborator

I'm pretty sure that the comment is added when you initialize things, but honestly I don't really know because my generator has all that stuff baked in and ready to go 😅

@jamesplease
Copy link
Contributor Author

It's entirely possible that the init command errored, and I just didn't notice it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants