fix issue #71 -Wrong contribution type being added to .all-contributorsrc #78
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import prompt from '../prompt' | ||
|
|
||
| function fixtures() { | ||
| const options = { | ||
| contributors: [ | ||
| { | ||
| login: 'jfmengels', | ||
| name: 'Jeroen Engels', | ||
| avatar_url: 'https://avatars.githubusercontent.com/u/3869412?v=3', | ||
| profile: 'https://github.com/jfmengels', | ||
| contributions: [Array], | ||
| }, | ||
| { | ||
| login: 'kentcdodds', | ||
| name: 'Kent C. Dodds', | ||
| avatar_url: 'https://avatars.githubusercontent.com/u/1500684?v=3', | ||
| profile: 'http://kentcdodds.com/', | ||
| contributions: [Array], | ||
| }, | ||
| { | ||
| login: 'jccguimaraes', | ||
| name: 'João Guimarães', | ||
| avatar_url: 'https://avatars.githubusercontent.com/u/14871650?v=3', | ||
| profile: 'https://github.com/jccguimaraes', | ||
| contributions: [Array], | ||
| }, | ||
| ], | ||
| } | ||
| return options | ||
| } | ||
|
|
||
| test(`should throw error if all contribution types are invalid`, () => { | ||
| const options = fixtures() | ||
| const username = 'userName' | ||
| const contributions = 'invalidContributionType1,invalidContributionType2' | ||
| expect(() => prompt(options, username, contributions)).toThrow( | ||
| 'Invalid contribution type/s entered', | ||
| ) | ||
| }) | ||
|
|
||
| test(`should not throw error if atleast one of the contribution types is valid`, () => { | ||
| const options = fixtures() | ||
| const username = 'userName' | ||
| const contributions = 'wrongContributionType,code' | ||
| return prompt(options, username, contributions).then(answers => { | ||
| expect(answers).toEqual({username: 'userName', contributions: ['code']}) | ||
| }) | ||
| }) | ||
|
|
||
| test(`should filter valid contribution types from user inserted types`, () => { | ||
| const options = fixtures() | ||
| const username = 'userName' | ||
| const contributions = | ||
| 'invalidContributionType1,code,invalidContributionType2,bug' | ||
| return prompt(options, username, contributions).then(answers => { | ||
| expect(answers.contributions.length).toBe(2) | ||
| expect(answers.contributions).toEqual(['code', 'bug']) | ||
| }) | ||
| }) | ||
|
|
||
| test(`should throw error if no contribution types were included in add command`, () => { | ||
| const options = fixtures() | ||
| const username = 'userName' | ||
| const contributions = '' | ||
| expect(() => prompt(options, username, contributions)).toThrow( | ||
| `No contribution type found in the input. Did you forget to include them in the add command?`, | ||
| ) | ||
|
There was a problem hiding this comment. If no contribution types are found in the add command, the user should be prompted for them. I should be able to just run the cli without any argument, be prompted for the operation I want to do (add/generate), then be prompted for the rest of the arguments. Currently your patch breaks that:
There was a problem hiding this comment. ok let us handle this in another pr then |
||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| const _ = require('lodash/fp') | ||
|
|
||
| const util = require('../util') | ||
|
|
||
| const linkTemplate = _.template( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be dealt with in another PR.