Use pytest on CI #252
Merged
Use pytest on CI #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beczkowb
approved these changes
May 7, 2021
iwko
reviewed
May 11, 2021
iwko
reviewed
May 11, 2021
| - uses: actions/checkout@v2 | ||
| - name: Set up Python 3.7 | ||
|
|
||
| - name: Checkout |
There was a problem hiding this comment.
It does not add a new step, just add name to it "Run actions/checkout@v2" => "Checkout"
iwko
reviewed
May 11, 2021
.github/workflows/python-app.yml
Outdated
| - name: Setup docker | ||
| run: | | ||
| sudo apt install apt-transport-https ca-certificates curl software-properties-common | ||
| curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add - | ||
| sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic test" | ||
| sudo apt update | ||
| sudo apt install docker-ce | ||
| sudo apt install docker-ce docker |
There was a problem hiding this comment.
you are right, fixed
iwko
reviewed
May 11, 2021
iwko
reviewed
May 11, 2021
| @@ -54,6 +54,7 @@ def test_check_dataflow_conflicts(self): | |||
|
|
|||
| @mock.patch('bigflow.build.dataflow.dependency_checker.detect_py_version') | |||
| @mock.patch('bigflow.build.spec.get_project_spec') | |||
| @unittest.skip("too slow - tmp disable") | |||
iwko
reviewed
May 11, 2021
iwko
reviewed
May 11, 2021
bigflow/commons.py
Outdated
| @@ -209,7 +209,7 @@ def run_process( | |||
| duration = time.time() - start | |||
| logger.debug("done in %s seconds, code %d", format(duration, ".2f"), process.returncode) | |||
|
|
|||
| return stdout | |||
| return stdout + "bad" | |||
There was a problem hiding this comment.
It is an intentional break.
anjensan
force-pushed
the
aj-use-pytest
branch
2 times, most recently
from
e6035c1 to
feff69d
Compare
beczkowb
approved these changes
Jun 8, 2021
iwko
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run unit tests on CI (github actions) via 'pytest'
Also attach pytest html report as zipped html file (contains tests duration & nice grouped output).