Another part of the partial fix. Needs more tests

allejo · Jan 19, 2018 · bb8a983 · bb8a983
1 parent ac67523
commit bb8a983
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/models/Player.php b/models/Player.php
@@ -360,6 +360,10 @@ public function invalidateMatchFromCache(Match $match)
         $seasonKey = $this->buildSeasonKeyFromTimestamp($match->getTimestamp());
         $seasonElo = null;
 
+        if (!isset($this->eloSeasonHistory[$seasonKey][$match->getId()])) {
+            return;
+        }
+
         $eloChangelogIndex = array_search($match->getId(), array_keys($this->eloSeasonHistory[$seasonKey]));
         $slicedChangeLog = array_slice($this->eloSeasonHistory[$seasonKey], 0, $eloChangelogIndex, true);
 

diff --git a/tests/ModelTests/MatchEloTest.php b/tests/ModelTests/MatchEloTest.php
@@ -67,7 +67,6 @@ public function testEloRecalculation()
 
         $matchToEdit = $matches[3];
 
-        $matchResult = $matchToEdit->getMatchDescription($team);
         $scoreTeamA = $matchToEdit->getScore($matchToEdit->getTeamA());
         $scoreTeamB = $matchToEdit->getScore($matchToEdit->getTeamB());
 
@@ -78,16 +77,8 @@ public function testEloRecalculation()
         $newLeaderElo = Player::get($team->getLeader())->getElo();
         $newTeamElo = Team::get($team->getId())->getElo();
 
-        if ($matchResult === 'win') {
-            $this->assertLessThan($preRecalcLeaderElo, $newLeaderElo);
-            $this->assertLessThan($preRecalcTeamElo, $newTeamElo);
-        } elseif ($matchResult === 'loss') {
-            $this->assertGreaterThan($preRecalcLeaderElo, $newLeaderElo);
-            $this->assertGreaterThan($preRecalcTeamElo, $newTeamElo);
-        } else {
-            $this->assertEquals($preRecalcLeaderElo, $newLeaderElo);
-            $this->assertEquals($preRecalcTeamElo, $newTeamElo);
-        }
+        $this->assertNotEquals($preRecalcLeaderElo, $newLeaderElo);
+        $this->assertNotEquals($preRecalcTeamElo, $newTeamElo);
     }
 
     /**