Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban enhancements #189

Open
Zehra opened this issue Apr 4, 2018 · 4 comments
Open

Ban enhancements #189

Zehra opened this issue Apr 4, 2018 · 4 comments

Comments

@Zehra
Copy link

Zehra commented Apr 4, 2018

Some minor enhancements.

  1. Active bans
    Currently, the expired and active bans are together, but no real indication besides dates.
    So maybe they could be somewhat highlighted or something?

Example:

Active bans:
Ban 123: Example_Player
Ban 124: Bad_Player_Two

Inactive/Expired bans:
Ban 122: Another_Player
Ban 121: Test_Player
...

  1. Ban deletion
    Currently bans do not appear to be able to be deleted, a ban might be made by mistake or needed to be recalled. (Might happen in the future.)

  2. Clickable links on ban page
    It sort of seems that clicking the area below the player where it says the ban date would be clickable.
    banned on [date] for ~[time]
    Making it clickable would feel more natural for most I'm thinking.

  3. Historical bans
    Probably not a priority, but maybe making it that historical bans aren't included by default in the ban list?

@allejo
Copy link
Owner

allejo commented Apr 4, 2018

Currently, the expired and active bans are together, but no real indication besides dates.
So maybe they could be somewhat highlighted or something?

Currently bans do not appear to be able to be deleted, a ban might be made by mistake or needed to be recalled. (Might happen in the future.)

I can get behind these 👍


Clickable links on ban page

Where would the links go to?

Probably not a priority, but maybe making it that historical bans aren't by default in the ban list?

This is a weird one... Historical bans are just regular bans that have been assigned to a player called "Historial whatever." It's not an actual feature of bzion so I'm not sure how much we can do about that.

@Zehra
Copy link
Author

Zehra commented Apr 4, 2018

Where would the links go to?

The links would go to the actual ban description is.
sample_link
(Area in red links to where the area in blue links to.)

This is a weird one... Historical bans are just regular bans that have been assigned to a player called "Historial whatever." It's not an actual feature of bzion so I'm not sure how much we can do about that.

I thought it was a separate category or something. (My bad.)

@allejo
Copy link
Owner

allejo commented Apr 4, 2018

Hmmm I'll have to think about making that a link; I'm hesitant to have two separate ways to get to the ban details from the same page. If the "right arrow" isn't clear enough, the design for that could be revisited if that's the case.

@Zehra
Copy link
Author

Zehra commented Apr 4, 2018

ban page

Maybe instead of an arrow it could be a button?
(This might make it a bit more mobile friendly too, but I'm not sure how well this would match with the theme.)
I'm also thinking hover text might be a good idea.
Maybe like "[player] ban details" appears by hovering the mouse on the button/arrow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants