Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D - Show Vol-E viewer in the viewport #546

Open
6 tasks
ShrimpCryptid opened this issue Feb 6, 2025 · 1 comment
Open
6 tasks

3D - Show Vol-E viewer in the viewport #546

ShrimpCryptid opened this issue Feb 6, 2025 · 1 comment
Labels
internals Tech debt, refactoring, dependencies, etc. new feature New feature or request

Comments

@ShrimpCryptid
Copy link
Contributor

ShrimpCryptid commented Feb 6, 2025

Use Case

Add Vol-E to the project and show a 3D view.

Acceptance Criteria

  • Add vole-core as a dependency of the project.
  • OPTIONAL: gate Vol-E behind a lazy load to reduce initial bundle size?
  • Add an onscreen button in the internal build mode that switches from the regular 2D viewer to the 3D vol-e viewport, with some test data loaded.
  • Keep existing CanvasOverlay functionality:
    • time stamp should be rendered above viewport
    • viewport + timestamp should appear in exported images and videos

Details

  • For the initial pass, OK to just show a default 3D volume and replace the existing viewport (dynamic switch will occur in 3D - Get 3D data source from dataset #547)
  • Will potentially need to rewrite the relationship between CanvasOverlay and ColorizeCanvas (make into sub-ticket?)
@ShrimpCryptid ShrimpCryptid added internals Tech debt, refactoring, dependencies, etc. new feature New feature or request labels Feb 6, 2025
@toloudis
Copy link
Contributor

toloudis commented Feb 6, 2025

I suggest that this can be simplified so that users don't make any decision. If the dataset is 3d, then use vole-core, else use the pre-existing viewport. No user switching yet

@ShrimpCryptid ShrimpCryptid changed the title 3D - Switch from the default viewport to the Vol-E viewer 3D - Show Vol-E viewer in the viewport Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Tech debt, refactoring, dependencies, etc. new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants