Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CanvasOverlay to be its own class, make generic Canvas #560

Open
3 tasks
ShrimpCryptid opened this issue Feb 7, 2025 · 0 comments
Open
3 tasks
Assignees
Labels
internals Tech debt, refactoring, dependencies, etc.

Comments

@ShrimpCryptid
Copy link
Contributor

Use Case

With the new 3D viewer, CanvasOverlay should no longer extend ColorizeCanvas but instead hold a reference to an abstract canvas.

Acceptance Criteria

  • Create an abstract Canvas that specifies shared canvas functionality (set parameters, getFrame, render, return DOM object)
  • ColorizeCanvas should extend/implement the abstract Canvas.
  • Change CanvasOverlay to be its own class that has a reference to an abstract Canvas.

Details

Would be easier if #502 is implemented

@ShrimpCryptid ShrimpCryptid added the internals Tech debt, refactoring, dependencies, etc. label Feb 7, 2025
@ShrimpCryptid ShrimpCryptid self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Tech debt, refactoring, dependencies, etc.
Projects
None yet
Development

No branches or pull requests

1 participant