Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last timepoint is (N-1)/N #303

Open
pgarrison opened this issue Aug 9, 2024 · 4 comments · Fixed by #334
Open

Last timepoint is (N-1)/N #303

pgarrison opened this issue Aug 9, 2024 · 4 comments · Fixed by #334
Assignees
Labels
bug Something isn't working

Comments

@pgarrison
Copy link

Description

The following ZARR has 121 frames, numbered from 0 to 120. The denominator for the "Time" slider is 121, which sort of makes sense because there are 121 frames. But this doesn't look good when I go to the final frame and see "120/121", suggesting that there is another frame after the end

https://allen-cell-animated.github.io/website-3d-cell-viewer/viewer?url=https%3A%2F%2Fallencell.s3.amazonaws.com%2Faics%2Femt_timelapse_dataset%2Fdata%2F3500005548_25_raw_converted.ome.zarr%2F


Below to be filled out by UX during kickoff Q&A to the best of current understanding

Size

Effort level (xs, sm, m, lg, xl)

Scope

What will we do? What will we NOT do?

User needs statement(s)

As a [type of user], I need/want to [action(s)], so that I can [goal].

Additional notes

Knowns/unknowns, stakeholders, time/dependency considerations, deliverables

@ShrimpCryptid ShrimpCryptid added the bug Something isn't working label Aug 10, 2024
@toloudis
Copy link
Contributor

@lynwilhelm Can you remember if we discussed this before and had any conclusions on what is best? We can also reference things like FIJI or Zen etc.

@toloudis
Copy link
Contributor

toloudis commented Nov 8, 2024

Zen and FIJI are both 1-based.

image

@pgarrison do you have a sense whether our web viewer should use 1-based or 0-based indexing when presenting these numbers to users?

@toloudis toloudis reopened this Nov 8, 2024
@lynwilhelm
Copy link
Contributor

The 1-based seems more intuitive to me but I only have a vague recollection of this discussion what I designed the sliders. @frasercl Do you recall and/or have a good argument for keeping it as-is?

@ShrimpCryptid
Copy link
Contributor

The 1-based seems more intuitive to me but I only have a vague recollection of this discussion what I designed the sliders. @frasercl Do you recall and/or have a good argument for keeping it as-is?

I have a note to check in with scientists on this... will update here once I do that on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants