Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use setChannelOptions more #159

Open
toloudis opened this issue Oct 26, 2023 · 0 comments
Open

use setChannelOptions more #159

toloudis opened this issue Oct 26, 2023 · 0 comments
Labels
milestone candidate Might be good to include in the next milestone Tech Debt

Comments

@toloudis
Copy link
Contributor

Use Case

We have too many code paths for setting the same settings.

Solution

For all of the top-level View3d api calls that set very specific data, we should have their internal implementations all be routed into our more generalized setChannelOptions. We can do this without changing the View3d api.

Alternatives

API changes to deprecate the single setting functions and then enforce setChannelOptions as the only public API is a bigger decision that has less effect on stability and could be considered separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone candidate Might be good to include in the next milestone Tech Debt
Projects
None yet
Development

No branches or pull requests

2 participants