Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to caching and request queue #250

Open
toloudis opened this issue Oct 3, 2024 · 0 comments
Open

improvements to caching and request queue #250

toloudis opened this issue Oct 3, 2024 · 0 comments

Comments

@toloudis
Copy link
Contributor

toloudis commented Oct 3, 2024

Use Case

The SubscribableRequestQueue has one main API problem: you can pass different actions in under the same key and id. And there is no way for the caller to know that their action may never be invoked.

Solution

Clean readable maintainable and understandable api's.

There isn't really an action item here apart from considering if we can re-engineer the caching and chunk fetching logic to be simpler while still handling the features we need (cancellable batches of chunk fetches, etc)

One thought experiment is to try inserting a proxy chunk in the cache before issuing the fetch. Then there is extra bookkeeping around cancellation but it might eliminate the need for the SubscribableRequestQueue.

The other idea floated in our discussion was to use a less object-oriented and more "database oriented" api and code flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant