From 9c89418a2d9df2b3737ff07cd59c02e45841a175 Mon Sep 17 00:00:00 2001
From: kyleclo <kyleclo@uw.edu>
Date: Thu, 10 Oct 2024 17:09:20 -0700
Subject: [PATCH] linting; mypy

---
 olmo/util.py                     |  3 +--
 scripts/compare_wandb_configs.py | 12 ++++++------
 tests/util_test.py               |  2 --
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/olmo/util.py b/olmo/util.py
index 55fc17336..3697e86ce 100644
--- a/olmo/util.py
+++ b/olmo/util.py
@@ -8,14 +8,13 @@
 import sys
 import time
 import warnings
-from collections import defaultdict
 from datetime import datetime
 from enum import Enum
 from itertools import cycle, islice
 from pathlib import Path
 from queue import Queue
 from threading import Thread
-from typing import Any, Callable, Dict, List, MutableMapping, Optional, Tuple, Union
+from typing import Any, Callable, Dict, MutableMapping, Optional, Tuple, Union
 
 import boto3
 import botocore.exceptions as boto_exceptions
diff --git a/scripts/compare_wandb_configs.py b/scripts/compare_wandb_configs.py
index f216a4f67..11e2907b9 100644
--- a/scripts/compare_wandb_configs.py
+++ b/scripts/compare_wandb_configs.py
@@ -96,15 +96,15 @@ def simplify_path(path):
 
 
 def print_data_differences(left_data_paths: Counter, right_data_paths: Counter):
-    print(f"===== Data Paths for left config:\n")
-    left_data_paths = {simplify_path(path): count for path, count in left_data_paths.items()}
-    for path, num_files in left_data_paths.items():
+    print("===== Data Paths for left config:\n")
+    simplified_left_data_paths = {simplify_path(path): count for path, count in left_data_paths.items()}
+    for path, num_files in simplified_left_data_paths.items():
         print(f"\t{path}: {num_files}")
     print("\n\n")
 
-    print(f"===== Data Paths for right config:\n")
-    right_data_paths = {simplify_path(path): count for path, count in right_data_paths.items()}
-    for path, num_files in right_data_paths.items():
+    print("===== Data Paths for right config:\n")
+    simplified_right_data_paths = {simplify_path(path): count for path, count in right_data_paths.items()}
+    for path, num_files in simplified_right_data_paths.items():
         print(f"\t{path}: {num_files}")
 
     return
diff --git a/tests/util_test.py b/tests/util_test.py
index b81ba6d8a..c3493458c 100644
--- a/tests/util_test.py
+++ b/tests/util_test.py
@@ -1,5 +1,3 @@
-from unittest import TestCase
-
 from olmo import util