Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlp_ratio not adjusted in config if mlp_hidden_size is set #673

Open
Muennighoff opened this issue Jul 21, 2024 · 0 comments
Open

mlp_ratio not adjusted in config if mlp_hidden_size is set #673

Muennighoff opened this issue Jul 21, 2024 · 0 comments
Labels
type/bug An issue about a bug

Comments

@Muennighoff
Copy link
Collaborator

🐛 Describe the bug

if mlp_hidden_size is set it overrides mlp_ratio but the resulting config will still have mlp_ratio = 4 (the default value) which is confusing when looking at the config in e.g. wandb. I think we should either have mlp_ratio default to None or overwrite the config value via mlp_hidden_size if set

Versions

latest

@Muennighoff Muennighoff added the type/bug An issue about a bug label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug An issue about a bug
Projects
None yet
Development

No branches or pull requests

1 participant