Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using memcache #11

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ jobs:
matrix:
php: [8.1, 8.2]
wordpress: ["latest"]
uses: alleyinteractive/.github/.github/workflows/php-tests.yml@main
uses: alleyinteractive/.github/.github/workflows/php-tests.yml@feature/object-cache
with:
database: ''
php: ${{ matrix.php }}
wordpress: ${{ matrix.wordpress }}
object-cache: "memcached"
4 changes: 2 additions & 2 deletions tests/Feature/FullPageCache404Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function test_feature_is_disabled_if_ssl_is_off(): void {
*/
public function test_feature_is_disabled_if_object_cache_is_not_in_use(): void {

if ( ! wp_using_ext_object_cache() ) {
if ( wp_using_ext_object_cache() ) {
$this->markTestSkipped( 'This test requires that an external object cache is in use.' );
}

Expand Down Expand Up @@ -113,7 +113,7 @@ public function test_feature_is_disabled_if_object_cache_is_not_in_use(): void {
*/
public function test_full_page_cache_404_returns_cache(): void {

if ( ! wp_using_ext_object_cache() ) {
if ( wp_using_ext_object_cache() ) {
$this->markTestSkipped( 'This test requires that an external object cache is in use.' );
}

Expand Down