Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to control the use of identityref types with values #118

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

gcampbell512
Copy link
Contributor

A new flag SCH_F_IDREF_VALUES has been created to control the addition of identityref information to leaf values.

A new flag SCH_F_IDREF_VALUES has been created to control the
addition of identityref information to leaf values.
@gcampbell512 gcampbell512 requested a review from carlgsmith July 16, 2024 22:17
Copy link
Contributor

@tony-vanderpeet tony-vanderpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it the flag gets set somewhere? Carl was thinking that this piece of code should be controlled by a flag, but I think he was thinking of the RESTCONF flag, which is not a schema flag.

@gcampbell512
Copy link
Contributor Author

There is an equivalent patch in apteryx-rest rest.c. The FLAG was named more for what it does than the generic term FLAG.._RESTCONF

@carlgsmith carlgsmith merged commit cfe9731 into alliedtelesis:master Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants