Add utils #5
Open
Add utils #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled out the bit extraction in the
cputo a file calledutilsthat could be used anywhere. Might not be the best name for something as specific as bit extraction but it's a start.I had plans to do some other stuff as well but I will make the pr's bite-sized for now. Since changing too much will be difficult to check.
PS: The makefile does not work as intended (it does not recompile) but the solution I can think of is just too much work and I don't know too much about
maketo do it, so I'm gonna leave it as it is for now.