Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allure-framework/allure-phpunit will require PHP 8.4 support #110

Open
glo71317 opened this issue Nov 6, 2024 · 3 comments
Open

allure-framework/allure-phpunit will require PHP 8.4 support #110

glo71317 opened this issue Nov 6, 2024 · 3 comments

Comments

@glo71317
Copy link

glo71317 commented Nov 6, 2024

Is your feature request related to a problem? Please describe.
PHP 8.4 is scheduled for general release on November 21, 2024 and we planned to php8.4 support for adobe commerce.

Describe the solution you'd like
We need to add php 8.4 support in composer.json and create one PR which is very straight forward. It may required some other dependency which will also required to get support php8.4.

Describe alternatives you've considered
I don't think there is any alternate will be available or help.

Additional context
NA

@glo71317
Copy link
Author

glo71317 commented Nov 6, 2024

@baev I hope you're doing well! With PHP 8.4 scheduled for general release on November 21, 2024, I was wondering if there are any plans to add support for PHP 8.4 in the allure-framework/allure-phpunit library.

I believe it would be a great addition for users who plan to upgrade to PHP 8.4, and it could help ensure that allure-phpunit remains compatible with the latest PHP features and improvements.

If you're open to it, I’d be happy to contribute a PR to help integrate PHP 8.4 support. Please let me know your thoughts, and I can proceed with drafting the necessary changes.

Thank you for your time and consideration!

@glo71317
Copy link
Author

@baev Greetings for the day! As PHP 8.4 is available for GA, So are we plan to add support PHP 8.4 for allure-framework/allure-phpunit because right now it is blocking to update the PHP 8.4 in adobe commerce. You will suggest if required from our end then we can also provide the PR for PHP 8.4 support. Thanks

@glo71317
Copy link
Author

glo71317 commented Dec 3, 2024

I have created a PR for PHP 8.4 Support - #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant