Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR: implemented in programming language #54

Open
cthoyt opened this issue Aug 12, 2022 · 7 comments
Open

NTR: implemented in programming language #54

cthoyt opened this issue Aug 12, 2022 · 7 comments
Assignees

Comments

@cthoyt
Copy link
Contributor

cthoyt commented Aug 12, 2022

It would be nice to have a property that is appropriate for connecting a software like HTSeq (SWO:1100140) to the programming language in which it's implemented like Python (SWO:0000118). This would be useful for the Data Science Ontology for better aligning with OBO as well. CC @epatters

I would label this relation implemented in programming language and it would have the following properties:

  1. Range: software (SWO:0000001)
  2. Domain: programming language (IAO:0000025)
@allysonlister
Copy link
Owner

That is a good idea. I need to tidy and make a new release here anyway, so happy to have this included. It's a volunteer project so may take a little bit of time. Thanks!

@cthoyt
Copy link
Contributor Author

cthoyt commented Aug 30, 2022

If you can point me to your contribution guidelines, I'd be happy to add something like this myself and send a PR.

@cthoyt
Copy link
Contributor Author

cthoyt commented Aug 30, 2022

For example, which file should I edit? Is there a release process? Or should I make the same change in multiple artifacts?

@cthoyt
Copy link
Contributor Author

cthoyt commented Aug 30, 2022

Also, it appears that is encoded in (SWO:0000741) has been previously used for doing this kind of thing, but this doesn't have an obvious label nor does it have specific constraints. Would it be better to continue using this, or to make a sub-property that has more strict domain/range and switch existing usages that conform to this?

@allysonlister
Copy link
Owner

SWO has been updated my a small number of people over a long period of time. Thanks for the offer - give me a few days to take a look at things and I'll get back to you wrt "is encoded in" as well as the build process (it is the build process itself that needs the main overhaul).

Thanks!

@cthoyt
Copy link
Contributor Author

cthoyt commented Aug 30, 2022

Thanks so much for the feedback! Ping me if/when you're ready for me to get involved.

@allysonlister
Copy link
Owner

allysonlister commented Mar 2, 2023

Sorry about the delay here.

is_encoded_in is intended to be quite generic, and applicable across different class types. You can see that because it has a child term has_format_specification that has a domain of data item and a range of data format specification.

We have two options:

  1. make a sub-property of is encoded in that has more strict domain/range and switch existing usages that conform to this.
  2. continue using is encoded in, but without the restrictions you mention perhaps it's not exactly what you need?

Item 2, which I'm leaning towards, would mean:

  • is encoded in - remains as-is, but could have better annotation
    • has format specification - remains as-is
    • implemented in programming language - with domain and range as you suggest

And then we would need to re-curate the existing software -> programming usages of is encoded in to be implemented in programming language

I would be very happy for you to contribute to this ticket. Information is in our contributing and editors documentation, and is built upon the standard ODK build procedure.

Essentially, update swo-edit.owl and then as for us to check your updates, then I can build the release once done.

example-id-ranges

Here's the setup for the ID ranges, and I've added your id range to the editors documentation. Note the non-standard EBI IRIs - this is a holdover of SWO as one of the very early OBO ontologies, developed at the EBI and I'm still torn about updating the IRIs, as the ontology is being used. Any additional thoughts here (with associated SWO ticket here) on that would be welcome too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants