Added missing label 'Textual format' from format_2330 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for submitting the change! I'll take a look at it tonight and get it all sorted. Please let me know if there's anything else you have questions about... |
|
Thanks very much for this - I appreciate the update. This has led me down a separate path which might involve some reorganization of the format hierarchy generally, which I will ponder for a while at #47 . Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst reviewing this ontology I noticed that a plain text format was missing from the "data format specification" hierarchy. Upon further inspection, format_2330 imported from the EDAM ontology is "Textual format", and is just missing the label.
My commit adds the label from EDAM to make it consistent with the other data formats that have been imported.