-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test warning on Frontstore #124
Merged
FranceBe
merged 10 commits into
develop
from
feature/ecom-1933-sfcc-warn-user-that-module-is-in-test-mode
Aug 16, 2024
Merged
Add test warning on Frontstore #124
FranceBe
merged 10 commits into
develop
from
feature/ecom-1933-sfcc-warn-user-that-module-is-in-test-mode
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartridges/int_alma/cartridge/scripts/helpers/almaCheckoutHelper.js
Outdated
Show resolved
Hide resolved
FranceBe
force-pushed
the
feature/ecom-1933-sfcc-warn-user-that-module-is-in-test-mode
branch
from
August 12, 2024 13:09
0ba49be
to
93d6113
Compare
Quality Gate passedIssues Measures |
Francois-Gomis
approved these changes
Aug 12, 2024
FranceBe
approved these changes
Aug 12, 2024
Benjamin-Freoua-Alma
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Code changes
Add a param in plans formatted for checkout and if we are in test mode, add ma warning in the checkout.
How to test
As a reviewer, you are encouraged to test the PR locally.
Go to the Storefront in test mode and see the warning on each Alma payment method.
Checklist for authors and reviewers
Non applicable