Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test warning on Frontstore #124

Merged

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

Add a param in plans formatted for checkout and if we are in test mode, add ma warning in the checkout.

How to test

As a reviewer, you are encouraged to test the PR locally.
Go to the Storefront in test mode and see the warning on each Alma payment method.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner August 2, 2024 07:27
@FranceBe FranceBe force-pushed the feature/ecom-1933-sfcc-warn-user-that-module-is-in-test-mode branch from 0ba49be to 93d6113 Compare August 12, 2024 13:09
Copy link

sonarcloud bot commented Aug 12, 2024

@Francois-Gomis Francois-Gomis self-requested a review August 12, 2024 13:39
@FranceBe FranceBe merged commit e5e2f91 into develop Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants