Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hmac verification on IPN #129

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

  • Add a security helper for check the signature
  • Use it in the Alma controller
  • Add some unit tests

How to test

As a reviewer, you are encouraged to test the PR locally.
You can only run unit tests with task test

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner September 11, 2024 15:01
Copy link

sonarcloud bot commented Sep 12, 2024

@joyet-simon joyet-simon merged commit a91c150 into main Sep 12, 2024
3 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-1820-sfcc-add-hmac-verification-on-ipn branch September 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants