Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Enable Vulnerability scanner on PR targeting develop #92

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

remic-alma
Copy link
Contributor

Reason for change

To match repository's gitflow, we need to enable Aqua scans on PR targeting develop.

Code changes

Modify aqua.yml workflow to trigger scan on PR targeting develop.

How to test

No test needed.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it

Non applicable

  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@remic-alma remic-alma removed the request for review from Francois-Gomis February 8, 2024 10:12
@joyet-simon joyet-simon merged commit fd37bea into develop Feb 13, 2024
3 checks passed
@joyet-simon joyet-simon deleted the security/enable_scan_on_pr_develop branch February 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants