Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client._request should not decode the response? #16

Open
umitanuki opened this issue May 28, 2018 · 1 comment
Open

Client._request should not decode the response? #16

umitanuki opened this issue May 28, 2018 · 1 comment

Comments

@umitanuki
Copy link
Contributor

Technically speaking, it is not correct or good to decode the response message with utf-8, since it is not text. Also, this may be adding overhead as well.

@bynr
Copy link
Contributor

bynr commented May 29, 2018

You are referring to this line right?
https://github.com/alpacahq/pymarketstore/blob/master/pymarketstore/client.py#L85

If we change the logic, then we can get rid of the following changes that were necessary for py2 compatibility

https://github.com/alpacahq/pymarketstore/blob/master/pymarketstore/client.py#L85
https://github.com/alpacahq/pymarketstore/blob/master/pymarketstore/results.py#L28

(just logging it for future reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants