Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate logic for building query requests, other basic code cleanups #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Consolidate logic for building query requests, other basic code cleanups #52

wants to merge 4 commits into from

Conversation

briancappello
Copy link
Contributor

  • moved the logic for building query requests into the Params class
  • consolidated get_timestamp and is_iterable into a utils module
  • cleaned up the imports

@dakimura
Copy link
Contributor

dakimura commented Aug 8, 2020

Thank you for the nice refactor, LGTM

@briancappello briancappello mentioned this pull request Aug 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakimura dakimura dakimura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briancappello @dakimura