Update 2021 ASLint #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @selfthinker
As you can see on the last pull request I have been playing around with the commits, sorry for that. I now want to make a single PR per tool and all base them of the current existing repo. In this manner you can add the tools one by one in any desired order or even not add them. If I added them all in a single PR one commit I think it would have been more work. If I am wrong you are more then welcome to tell me :D.
For the ASLint update the two main changes are: I set every warning to error. It because I didnt see any difference between warning and error in the tool. The only difference I did spot is that 3 layers if interface down there is a severity level which I didn't experience as a real difference between either a warning or error. I'll leave it up to you as maintainers to make the decision on how to register them. Also some of the results were labelled to "identified" since no specific output was generated by the tool while running the related testcases I considered this feature removed.
Kind Regards,