Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack::Attack needs a better way of alerting us if it's failed or succeeded! #1431

Open
KludgeKML opened this issue May 19, 2022 · 0 comments

Comments

@KludgeKML
Copy link
Contributor

Currently we just have Rack::Attack on the defaultish settings for throttling requests. But that gives us no oversight on when throttling is happening, and we also don't have an alert if the throttling is disabled on startup either by the explicit DISABLE_THROTTLE var being set or by there being no REDIS_URL.

Perhaps the rate-limit state could go into the health check (although that's public, and maybe we don't want to advertise whether the rate-limit is turned on?). We could maybe have a specific rate-limit health check that Smokey can call, using the rate-limit-token as an accessor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant