Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page images from content item #4375

Closed
wants to merge 5 commits into from

Commits on Nov 5, 2024

  1. Add helper to allow remote or local images

    - Because we might now get images from the content item or locally-supplied, we check the url is a url - if it is, we return it, if not, we try to make an image_path for it and return that.
    KludgeKML committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ca0fc49 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add HasImageSet concern

    - this will replace individual image handling in hero and featured blocks.
      Tests to be added in the commits for the consuming block types.
    - to simplify calls, we load the sources into an OpenStruct. This is
      close to how they're currently handled in the blocks, but removes the
      Dataclass strictness (which allows this to be used more generally).
    KludgeKML committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    579c191 View commit details
    Browse the repository at this point in the history
  2. Use HasImageSet concern in Hero block.

    - Update tests and fixtures (local files to be updated in a later commit)
    KludgeKML committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c80041d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a322ce6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83e008f View commit details
    Browse the repository at this point in the history