"times" seems superfluous

[Jameskmonger]

The times property in Expect(some.function).toHaveBeenCalled(3).times seems very unnecessary. I think that as a library we should be encouraging good, clean code - not using variables which don't do anything but increase readability.

I find it to be slightly confusing if I don't understand the library - why is someone using a variable as a statement?

If you want to keep a syntax, maybe we could do something like FakeItEasy:

Expect(some.function).toHaveBeenCalled(Repeated.Times(5))

[jamesadarich]

@Jameskmonger yeah, let's have this as a discussion task to find a way to implement the current functionality. This will have to go in > 2.0.0 as it's an API change 👍

[Jameskmonger]

Expect(some.function).toHaveBeenCalled();
Expect(some.function).toHaveBeenCalled(Repeated.Exactly.Times(3));
Expect(some.function).toHaveBeenCalled(Repeated.AtLeast.Times(3));
Expect(some.function).toHaveBeenCalled(Repeated.AtMost.Times(3));

I think the above syntax is good for toHaveBeenCalled - toHavebeenCalledWith will take more thought.

[jamesadarich]

I think we should probably leave the Repeated out in this case as it's a bit of extra unnecessary (and that's what we're trying to achieve in this task ;) )

Will need a bit more thought for toHaveBeenCalledWith

Probably the neatest I can think of now is similar to how it is now.

Expect(some.function).toHaveBeenCalledWith().exactly.times(4);
Expect(some.function).toHaveBeenCalledWith().atLeast.times(4);
Expect(some.function).toHaveBeenCalledWith().atMost.times(4);

Expect(some.function).toHaveBeenCalledWith("some", "arguments").exactly.times(4);
Expect(some.function).toHaveBeenCalledWith("some", "arguments").atLeast.times(4);
Expect(some.function).toHaveBeenCalledWith("some", "arguments").atMost.times(4);

[Jameskmonger]

Perfect, that looks good to me @jamesrichford.

[jamesadarich]

Another thought on this one @Jameskmonger maybe we should remove the extra dot chain i.e.

Expect(some.function).toHaveBeenCalledWith().exactlyTimes(4);
Expect(some.function).toHaveBeenCalledWith().atLeastTimes(4);
Expect(some.function).toHaveBeenCalledWith().atMostTimes(4);

Expect(some.function).toHaveBeenCalledWith("some", "arguments").exactlyTimes(4);
Expect(some.function).toHaveBeenCalledWith("some", "arguments").atLeastTimes(4);
Expect(some.function).toHaveBeenCalledWith("some", "arguments").atMostTimes(4);

[Jameskmonger]

Potentially we could, but I think it may fit well with our not modifier.

[jamesadarich]

@Jameskmonger where would the not be here?