Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement specifying ts-config to alsatian-cli #600

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hisuwh
Copy link
Contributor

@hisuwh hisuwh commented Nov 3, 2019

Description

Allow specifying ts-config.
Closes #599

Checklist

  • I am an awesome developer and proud of my code
  • I added / updated / removed relevant unit or integration tests to prove my change works
  • I ran all tests using npm test to make sure everything else still works

@hisuwh
Copy link
Contributor Author

hisuwh commented Dec 23, 2019

@jamesadarich I could do with some guidance on where I need to add tests for this?

@jamesadarich
Copy link
Member

Yeah, no worries we can catch up on Monday :)

@mwgamble
Copy link

mwgamble commented Jan 28, 2020

It would also be nice if there was integration with the tsconfig-paths package. Right now I'm maintaining my own CLI script to start alsatian, and this PR alone wouldn't be enough to change that:

https://github.com/cashmoneyjs/cashmoney/blob/master/run-tests.js

Reviewing it again, I realised it would be good if there was also a "bootstrap" flag to require a file that performs initial setup, such as extensions for Expect:

https://github.com/cashmoneyjs/cashmoney/blob/master/tests/bootstrap.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify ts-config.json file to use for running tests
3 participants