Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support public imports #4

Open
2 tasks
ydnar opened this issue Jun 19, 2020 · 2 comments
Open
2 tasks

Support public imports #4

ydnar opened this issue Jun 19, 2020 · 2 comments
Labels
feature New feature or request

Comments

@ydnar
Copy link
Contributor

ydnar commented Jun 19, 2020

A proto file imported from another proto file using import public ... will have its exported types aliased in the generated Go code, and vars copied. Currently the Go code generator doesn’t check to see if the imported symbols clobber existing symbols in the importing package.

  • Ensure symbols imported using import public are renamed when aliased or copied into the destination package.
  • Consider an option to rename the symbol in an importing package.
@ydnar ydnar added the feature New feature or request label Jun 19, 2020
@flymedllva
Copy link

And is there an example of how to use with a buf?

@ydnar
Copy link
Contributor Author

ydnar commented Aug 20, 2022

Great question. I’d accept an example with tests in a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants