Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Build Failing #70

Open
playermanny2 opened this issue May 15, 2019 · 1 comment
Open

Travis Build Failing #70

playermanny2 opened this issue May 15, 2019 · 1 comment
Assignees

Comments

@playermanny2
Copy link
Collaborator

Currently, the travis build fails due to cypress integration test failing (opening_files.js). Specifically one part of the test fails when testing 'Open With -> Voyager'.

This is a known issue due to a disconnect between jupyterlab expecting native click events, while cypress triggers the context menu not via native events. There are milestones for both Jupyterlab and Cypress in order to address this disconnection, but there's no real date in mind for the feature update. More info on the issue can be followed here

This also can hinder writing tests for future features...I think there are two options here

  1. Wait on the issue to be corrected from either the jupyerlab side or cypress side
  2. Utilize another testing framework (potentially jest)

@saulshanabrook

@saulshanabrook
Copy link
Collaborator

@playermanny2 I am happy with either approach. I am not actively looking into fixing the issue, so if you would like to switch to another testing approach I would support that!

@playermanny2 playermanny2 self-assigned this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants