Updates test suite re-enables encode : in version and / in qualifier values and assert Maven requirement of namespace
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criminosis
commented
Nov 4, 2022
| @@ -25,7 +25,7 @@ impl<'a> SpecTestCase<'a> { | |||
| let json = v | |||
| .into_iter() | |||
| .find(|x| x["description"].as_str().unwrap().eq(desc)) | |||
| .unwrap(); | |||
There was a problem hiding this comment.
This kind of helped grok how to make changes to the test suite, so figured I'd offer it up to give any future new contributors some more context than just a generic error message.
criminosis
changed the title
: in version and / in qualifier values and assert Maven requirement of namespace
|
@criminosis I am pushing out a new release of the crate. I am not sure about the state of this PR. Maybe you can refresh it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6