Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stage): add auth stage #9

Merged
merged 13 commits into from
Jun 10, 2024
Merged

feat(stage): add auth stage #9

merged 13 commits into from
Jun 10, 2024

Conversation

alvinsj
Copy link
Owner

@alvinsj alvinsj commented Jun 9, 2024

Story: simplify auth stages

  1. Why this change is required?
    • make clearer code
  2. What problem does it solve?
    • auth stages is ambiguos and messy

Implementation

  1. add AuthStage
  2. handle AuthStage in abstraction
  3. minor fixes

Checklist

  • Fulfilled specs
  • Ensured code is readable
  • Consistency in architecture
  • Added Test

@alvinsj alvinsj merged commit d088746 into main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alvinsj