Skip to content

Commit

Permalink
Addressed CMD check comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alwinw committed May 4, 2022
1 parent d19a00b commit b69b459
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 19 deletions.
5 changes: 3 additions & 2 deletions .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.covrignore
^_pkgdown\.yml$
^.*\.Rproj$
^.covrignore
^.pytest_cache
^\.github$
^\.png$
Expand All @@ -9,6 +9,7 @@
^\.travis\.yml$
^appveyor\.yml$
^codecov\.yml$
^codemeta.json
^cran-comments.md$
^CRAN-RELEASE$
^data-raw$
Expand All @@ -24,4 +25,4 @@
^README\.Rmd$
^renv\.lock$
^renv$
^resources$
^resources$
32 changes: 15 additions & 17 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,18 @@
# Resubmission
# Release Summary

Resubmission of `epocakir`, version bumped to v0.9.7. In this version:
Submission of `epocakir`, version bumped to v0.9.8. In this version:

- Added reference link in the description field of the DESCRIPTION file
- Reduced the length of the title to less than 65 characters
- Added \value to .Rd files regarding exported methods and explain the functions results in the documentation
- aki_staging.Rd: Added return value
- pipe.Rd: Removed code that re-exported %>% and used @importFrom instead
- Updated README and description
- Addressed comments from `goodpractice::gp()`

## R CMD check results

> checking CRAN incoming feasibility ... NOTE
Maintainer: 'Alwin Wang <[email protected]>'
```console
-- R CMD check results ----------------------------------- epocakir 0.9.8 ----
Duration: 1m 31.9s

New submission

0 errors v | 0 warnings v | 1 note x

- Note due to new submission
- Note possibly mis-spelled words 'AKI', 'CKD', 'KDIGO', are all medical abbreviations spelt correctly
0 errors √ | 0 warnings √ | 0 notes √
```

## Test Environments

Expand All @@ -32,8 +26,12 @@ Resubmission of `epocakir`, version bumped to v0.9.7. In this version:
- win-builder: R-devel, R-release, R-oldrelease
- R-hub: Windows R-devel, Ubuntu R-release, Fedora R-devel

- Checks: `devtools::spell_check()`, `devtools::check_rhub()`, `devtools::check_win_devel()`, `goodpractice::gp()`,
`rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")`
- Checks:
- `goodpractice::gp()`,
- `rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")`
- `devtools::spell_check()`,
- `devtools::check_rhub()`,
- `devtools::check_win_devel()`,

## Revdep Checks

Expand Down

0 comments on commit b69b459

Please sign in to comment.