Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Translations for "Never Opened" and "Last Opened" #696

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7c941bc
Added String Resources for "Never Opened" & "Last Opened"
FareesHussain Nov 12, 2020
4c8ccbb
Fixed string resource errors in strings.xml-te
FareesHussain Nov 12, 2020
5f91d1a
Update gradle-wrapper.properties
FareesHussain Dec 5, 2020
c06e0b5
Merge branch 'beta' of https://github.com/amahi/android into beta
FareesHussain Dec 22, 2020
45a757f
Resolving requested changes
FareesHussain Dec 23, 2020
4f2b9db
Resolving requested changes
FareesHussain Dec 29, 2020
1076682
Lint strings file
chirag-jn Dec 31, 2020
520f237
lint AlertDialogFragment
chirag-jn Dec 31, 2020
e331b4e
Merge branch 'beta' of https://github.com/amahi/android into beta
FareesHussain Feb 27, 2021
565648b
Update strings.xml
chirag-jn Feb 27, 2021
86d5dfe
Fix errors
FareesHussain Feb 27, 2021
3634f07
Merge remote-tracking branch 'origin/beta' into beta
FareesHussain Feb 27, 2021
d28e196
Merge branch 'beta' of https://github.com/amahi/android into beta
FareesHussain Feb 27, 2021
f95e564
Updates values-te/strings.xml
chirag-jn Feb 27, 2021
71b5e6e
Update values/strings.xml
chirag-jn Feb 27, 2021
975ba85
Add chinese to values/strings.xml
chirag-jn Feb 27, 2021
fe8d44a
Add back press toast message
chirag-jn Feb 27, 2021
7063bf8
Merge branch 'beta' into beta
chirag-jn Feb 28, 2021
ef929b4
Merge branch 'beta' into beta
chirag-jn Mar 5, 2021
dd2737d
Added last opened and never opend for chinese, panjabi and telugu
FareesHussain Mar 5, 2021
a84b3ff
Merge remote-tracking branch 'origin/beta' into beta
FareesHussain Mar 5, 2021
ceda97a
removed duplicate strings
FareesHussain Mar 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class AlertDialogFragment extends DialogFragment implements DialogInterfa
public static final int DUPLICATE_FILE_DIALOG = 1;
public static final int SIGN_OUT_DIALOG = 3;
public static final int FILE_INFO_DIALOG = 2;
public static final String LAST_OPENED_NULL = "Never opened";
public final String LAST_OPENED_NULL = getString(R.string.never_opened);
FareesHussain marked this conversation as resolved.
Show resolved Hide resolved


@NonNull
Expand Down
2 changes: 1 addition & 1 deletion src/main/res/layout/file_info_dialog.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TextView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Last opened"
android:text="@string/last_opened"
android:textSize="14sp"
android:paddingStart="8dp"
android:paddingEnd="0dp"
Expand Down
2 changes: 2 additions & 0 deletions src/main/res/values-bn/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -190,4 +190,6 @@
<string name="notification_offline_download_error">ফাইল অফলাইনে উপলব্ধ করায় ত্রুটি</string>
<string name="notification_offline_download_paused">ইন্টারনেটের জন্য অপেক্ষা করা হচ্ছে</string>
<string name="preference_entry_server_connection_local">LAN</string>
<string name="never_opened">কখনও খোলা হয়নি</string>
<string name="last_opened">সর্বশেষ খোলা</string>
</resources>
3 changes: 2 additions & 1 deletion src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -208,5 +208,6 @@
<string name="size_largest">Tamaño (el más grande primero)</string>
<string name="size_smallest">Tamaño (el más pequeño primero)</string>
<string name="file_type">Tipo de archivo</string>

<string name="never_opened">Nunca Abierta</string>
<string name="last_opened">Abierto por última vez</string>
</resources>
3 changes: 2 additions & 1 deletion src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,6 @@
<string name="size_largest">Taille (la plus grande en premier)</string>
<string name="size_smallest">Taille (la plus petite en premier)</string>
<string name="file_type">Type de fichier</string>

<string name="never_opened">Jamais ouvert</string>
<string name="last_opened">Dernière ouverture</string>
</resources>
4 changes: 3 additions & 1 deletion src/main/res/values-te/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<string name="message_delete_file_title">తొలగింపును నిర్ధారించాలా?</string>
<string name="message_delete_progress">సాధ్యం కాదు.</string>
<string name="message_duplicate_file_upload">ప్రస్తుత ఫైల్‌కు వ్రాయాలనుకుంటున్నారా?</string>
<string name="message_duplicate_file_upload_body">ఈ ఫైల్% 1 $ s ఇప్పటికే ఉంది. ఖచ్చితంగా మీరు ఇప్పటికే ఉన్న ఫైల్‌ను భర్తీ చేయాలనుకుంటున్నారా?</string>
<string name="message_duplicate_file_upload_body">ఈ ఫైల్ %1$s ఇప్పటికే ఉంది. ఖచ్చితంగా మీరు ఇప్పటికే ఉన్న ఫైల్‌ను భర్తీ చేయాలనుకుంటున్నారా?</string>
<string name="message_empty_apps">తప్పిపోయిన అనువర్తనాలు</string>
<string name="message_empty_files">తప్పిపోయిన ఫైల్</string>
<string name="message_empty_recent_files">ఇటీవలి ఫైల్ లేదు</string>
Expand Down Expand Up @@ -194,4 +194,6 @@
<string name="preference_entry_server_connection_local">LAN</string>
<string name="title_no_server">సర్వర్‌లు లేవు</string>
<string name="file_type">ఫైల్ రకం</string>
<string name="never_opened">ఎప్పుడూ తెరవలేదు</string>
<string name="last_opened">చివరిగా తెరవబడింది</string>
</resources>
2 changes: 2 additions & 0 deletions src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@

<string name="alert_delete_dialog">Delete file</string>
<string name="alert_delete_confirm">Are you sure?</string>
<string name="never_opened">Never Opened</string>
<string name="last_opened">Last Opened</string>
Comment on lines +177 to +178
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add never_opened and last_opened for values-zh (Chinese) too. Rest seems fine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I'll do it now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done please check


<string name="title_file_info">File Info</string>
<string name="text_ok">OK</string>
Expand Down