Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DockerFile to ubuntu 20.04; correct OS check issue; run build automatically #19

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

xdddduo
Copy link
Contributor

@xdddduo xdddduo commented Jun 11, 2024

I fixed two issues I met when installing avr using docker:

  1. Changed environment to be ubuntu 20.04 (otherwise would have problem finding distutils, which is already deprecated in Python 3.12, the version Ubuntu 24.04 is using)
  2. Added a line to modify the OS checking in Dockerfile before building build.sh (otherwise would recheck OS though it is already using ubuntu. And since docker shares the kernal with the host, there would be no 'ubuntu' when doing uname -a), leading to excuting yum in original version)

@xdddduo
Copy link
Contributor Author

xdddduo commented Jun 16, 2024

I also revised DockerFile to resolve the prompt of time zone. So the latest version does need to run build.sh by hand.

@xdddduo xdddduo changed the title Change DockerFile to ubuntu 20.04 and correct OS check issue Change DockerFile to ubuntu 20.04; correct OS check issue; run build automatically Jun 16, 2024
@aman-goel aman-goel merged commit 833b13a into aman-goel:master Jun 18, 2024
1 check passed
@aman-goel
Copy link
Owner

@xdddduo Thanks for these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants