improved type inference for localePrefix in defineRouting

[stefanprobst]

see https://www.typescriptlang.org/es/play/?#code/JYWwDg9gTgLgBAbzgEwKYDNgDtUCUICuM2A5nAL5zpQQhwBEOAHjALTYwA2A9DUafQDcAKGEBjCFgDO8PsSxkAvCgzY8heSQAUCYXDicIYgIadUUgFxwA2vTSsAggBV6AGgaosrAOIAhegC6rnoq6MYEnDAAMkamqFb0nj7+wfqGJmYAClCqTFa6+vogEGgJpgDuxgCeUm4h+mA5mEzm+fWFdqiOLgncaHWFHUl+9L2eA4XkqRTB5ACUIuKSMgaxWU3ATHDKcqQAdOlx2bnt+tzccAB6APxL0vCNuebbcLsKB2uox817j83mpzg5yutyAA

when i provide a localePrefix config object to defineRouting it would be cool if defineRouting would return the shape of that object instead of an optional LocalePrefix type (see the typescript playground above)

[amannn]

I agree that the returned routing object would ideally be typed based on the exact shape of what was passed in.

This function was quite tricky to get right though:

• https://discord.com/channels/997886693233393714/1278008400533520434
• feat: Add defineRouting for easier i18n routing setup #1299

Do you have a practical case where the current behavior is problematic?

[stefanprobst]

Do you have a practical case where the current behavior is problematic?

definitely not problematic, just a nice-to-have. e.g. for a helper fn like this, which i use when generating sitemap and rss feed links for different locales:

function getLocalePrefix(locale: Locale) {
  const prefix = routing.localePrefix.prefixes[locale];

  return prefix;
}

[amannn]

Hmm, why do you have to construct prefixes yourself? Have you considered using getPathname to create sitemap entries?

[stefanprobst]

oh 👀 i totally wasn't aware of getPathname!

btw i think there's a typo in the docs at https://next-intl.dev/docs/routing/navigation#getpathname

-    params: {sortBy: 'name'}
+    query: {sortBy: 'name'}

[amannn]

Oh, right—thanks! Fixed in d4d5b4a.