Skip to content
This repository has been archived by the owner on Mar 8, 2019. It is now read-only.

Emission of :responseReady makes code exists before ical.fromURL callback is called #45

Open
lpatire opened this issue Feb 1, 2018 · 0 comments

Comments

@lpatire
Copy link

lpatire commented Feb 1, 2018

This line:

204 this.emit(':responseReady');

is making the handler to return a response without waiting the ical.fromURL callback to be called.

Therefore, all the requests I'm sending receives a response as:

{ "version": "1.0", "response": { "shouldEndSession": true }, "sessionAttributes": { "STATE": "_SEARCHMODE" }, "userAgent": "ask-nodejs/1.0.25 Node/v6.10.3" }

After removing that line, the application gets back to normal responses!
Can we take it off?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant