Skip to content

Commit

Permalink
enable enhanced container insights flag in emf exporter (#131)
Browse files Browse the repository at this point in the history
  • Loading branch information
lisguo authored Oct 25, 2023
1 parent dc59406 commit 10cc00e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions exporter/awsemfexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ func (config *Config) Validate() error {
}

func (config *Config) IsEnhancedContainerInsights() bool {
return false // temporarily disable, also need to rename _config to config
// return config.EnhancedContainerInsights && !config.DisableMetricExtraction
return config.EnhancedContainerInsights && !config.DisableMetricExtraction
}

func (config *Config) IsAppSignalsEnabled() bool {
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func TestIsEnhancedContainerInsights(t *testing.T) {
cfg := factory.CreateDefaultConfig().(*Config)
cfg.EnhancedContainerInsights = true
cfg.DisableMetricExtraction = false
assert.False(t, cfg.IsEnhancedContainerInsights())
assert.True(t, cfg.IsEnhancedContainerInsights())
cfg.EnhancedContainerInsights = false
assert.False(t, cfg.IsEnhancedContainerInsights())
cfg.EnhancedContainerInsights = true
Expand Down

0 comments on commit 10cc00e

Please sign in to comment.