tweaks for enhanced container insights metrics #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitali-salvi
previously approved these changes
Sep 21, 2023
sky333999
previously approved these changes
Sep 21, 2023
|
holding off on merge until Zhihong has upgraded otel. Then I will rebase and fix conflicts |
chadpatel
force-pushed
the
enhanced-ci-tweaks
branch
from
985feb7 to
b0c5c90
Compare
chadpatel
dismissed stale reviews from sky333999 and mitali-salvi
via
060ad04
chadpatel
merged commit dd840b7
into
amazon-contributing:aws-cwa-dev
85 of 87 checks passed
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
* tweaks for enhanced container insights metrics * run go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tweaking enhanced container insights based on most recent asks.
High level
Link to tracking Issue:
Testing:
I built the changes into CCWA and deployed them to my test cluster
Crash:
No crashes:
New kube-apiserver metrics
Documentation: Updated README