Improved client logs (#167)

amazon-contributing · Jul 3, 2024 · 1e07acc · 1e07acc
1 parent b381062
commit 1e07acc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/redis/src/aio/connection.rs b/redis/src/aio/connection.rs
@@ -28,6 +28,7 @@ use std::net::{IpAddr, SocketAddr};
 use std::pin::Pin;
 #[cfg(any(feature = "tokio-comp", feature = "async-std-comp"))]
 use tokio_util::codec::Decoder;
+use tracing::info;
 
 /// Represents a stateful redis TCP connection.
 #[deprecated(note = "aio::Connection is deprecated. Use aio::MultiplexedConnection instead.")]
@@ -451,6 +452,7 @@ pub(crate) async fn connect_simple<T: RedisRuntime>(
         ConnectionAddr::Tcp(ref host, port) => {
             let socket_addrs = get_socket_addrs(host, port).await?;
             select_ok(socket_addrs.map(|socket_addr| {
+                info!("IP of node {:?} is {:?}", host, socket_addr.ip());
                 Box::pin(async move {
                     Ok::<_, RedisError>((
                         <T>::connect_tcp(socket_addr).await?,
@@ -477,6 +479,7 @@ pub(crate) async fn connect_simple<T: RedisRuntime>(
             }
             let socket_addrs = get_socket_addrs(host, port).await?;
             select_ok(socket_addrs.map(|socket_addr| {
+                info!("IP of node {:?} is {:?}", host, socket_addr.ip());
                 Box::pin(async move {
                     Ok::<_, RedisError>((
                         <T>::connect_tcp_tls(host, socket_addr, insecure, tls_params).await?,

diff --git a/redis/src/cluster_async/mod.rs b/redis/src/cluster_async/mod.rs
@@ -794,7 +794,8 @@ impl<C> Future for Request<C> {
                         .into();
                     }
                 };
-                trace!("Request error `{}` on node `{:?}", err, address);
+
+                warn!("Received request error {} on node {:?}.", err, address);
 
                 match err.retry_method() {
                     crate::types::RetryMethod::AskRedirect => {