Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for serialization of common file/mime types #71

Open
kennedymwavu opened this issue Sep 11, 2024 · 0 comments
Open

add support for serialization of common file/mime types #71

kennedymwavu opened this issue Sep 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kennedymwavu
Copy link
Contributor

new feature

currently, we have handled serialization of the MOST common file types, as seen in the docs.

it would be valuable if we add support for these too:

  • pdf
  • xls
  • xlsx
  • ods

why

most R users often need to generate reports. in most cases, the reports are pdfs, a result of rendering via .Rmd or .qmd.

they also happen to use MS Excel and Libre Office a lot, so exporting of the results of an analysis to an xlsx or ods file is popular.

hint

we can make use of the mime map already in Yihui's {mime} pkg.
this will, foreseeably, end up simplifying how the response object handles "file downloads" internally.

in the end, we can have a standardized API for handling "downloads", possibly by extending res$send_file() to handle more file types.

@kennedymwavu kennedymwavu added the enhancement New feature or request label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant